Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2984)

Unified Diff: blimp/engine/BUILD.gn

Issue 2371233002: Blob Channel failed to register service (Closed)
Patch Set: add an output pak in the grd file and have blimp/engine:pak depend on it Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 3c7918789fe0ae918f9a2535841bad390baab75b..521db30f0655a4428f1d7aba4472c078c4deebe8 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -12,6 +12,7 @@ import("//tools/grit/grit_rule.gni")
repack("pak") {
sources = [
+ "$root_gen_dir/blimp/blimp_browser_resources.pak",
nyquist 2016/09/27 20:48:48 Does this mean that this will also work within the
Menglin 2016/09/27 22:06:40 Yes. I verified the engine starts correctly in the
"$root_gen_dir/blink/public/resources/blink_image_resources_100_percent.pak",
"$root_gen_dir/blink/public/resources/blink_resources.pak",
"$root_gen_dir/content/app/resources/content_resources_100_percent.pak",
@@ -26,6 +27,7 @@ repack("pak") {
]
deps = [
+ ":resources",
"//content:resources",
"//content/app/resources",
"//content/app/strings",
@@ -46,6 +48,16 @@ repack("pak") {
output = "$root_out_dir/blimp_engine.pak"
}
+grit("resources") {
nyquist 2016/09/27 20:48:48 Should this have visibility = [ ":*" ]?
Menglin 2016/09/27 22:06:40 Done.
+ source = "app/blimp_browser_resources.grd"
+ use_qualified_include = true
+ output_dir = "$root_gen_dir/blimp"
nyquist 2016/09/27 20:48:48 Should this be $root_gen_dir/blimp/engine ?
Menglin 2016/09/27 22:06:40 Done.
+ outputs = [
+ "grit/blimp_browser_resources.h",
+ "blimp_browser_resources.pak",
+ ]
+}
+
source_set("app") {
sources = [
"app/blimp_browser_main_parts.cc",
@@ -88,6 +100,7 @@ source_set("app") {
"//content/public/utility",
"//device/geolocation",
"//net",
+ "//ui/base:base",
]
}
« no previous file with comments | « no previous file | blimp/engine/app/blimp_browser_resources.grd » ('j') | blimp/engine/app/blimp_content_browser_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698