Blob Channel failed to register service

blimp/engine/app/blimp_content_browser_client.cc

Index: blimp/engine/app/blimp_content_browser_client.cc
diff --git a/blimp/engine/app/blimp_content_browser_client.cc b/blimp/engine/app/blimp_content_browser_client.cc
index b46470fd00db44d052ef8683f98d9ab35401a912..a88d92e50c9731182d46b35f776c96b81c5e9028 100644
--- a/blimp/engine/app/blimp_content_browser_client.cc
+++ b/blimp/engine/app/blimp_content_browser_client.cc
@@ -2,12 +2,16 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/json/json_reader.h"
 #include "blimp/engine/app/blimp_browser_main_parts.h"
 #include "blimp/engine/app/blimp_content_browser_client.h"
 #include "blimp/engine/app/settings_manager.h"
 #include "blimp/engine/mojo/blob_channel_service.h"
+#include "blimp/grit/blimp_browser_resources.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/common/service_names.h"
 #include "services/shell/public/cpp/interface_registry.h"
+#include "ui/base/resource/resource_bundle.h"
 
 namespace blimp {
 namespace engine {
@@ -48,5 +52,21 @@ void BlimpContentBrowserClient::ExposeInterfacesToRenderer(
       base::Unretained(blimp_browser_main_parts_->GetBlobChannelService())));
 }
 
+std::unique_ptr<base::Value>
+BlimpContentBrowserClient::GetServiceManifestOverlay(
+    const std::string& name) {
+  VLOG(0) << "mlliu: GetServiceManifestOverlay" << name;

[Ken Rockot(use gerrit already), 2016/09/27 19:05:43]

Does this run?

+  ResourceBundle& rb = ResourceBundle::GetSharedInstance();
+  int id = -1;
+  if (name == content::kBrowserMojoApplicationName)
+    id = IDR_BLIMP_CONTENT_BROWSER_MANIFEST_OVERLAY;
+  if (id == -1)
+    return nullptr;
+
+  base::StringPiece manifest_contents =

[Ken Rockot(use gerrit already), 2016/09/27 19:05:43]

Is this the value you expect?

+      rb.GetRawDataResourceForScale(id, ui::ScaleFactor::SCALE_FACTOR_NONE);
+  return base::JSONReader::Read(manifest_contents);
+}
+
 }  // namespace engine
 }  // namespace blimp