Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(21)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: blimp/engine/app/blimp_browser_resources.grd
Issue
2371233002
:
Blob Channel failed to register service (Closed)
Patch Set: add an output pak in the grd file and have blimp/engine:pak depend on it
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
blimp/engine/BUILD.gn
blimp/engine/app/blimp_browser_resources.grd
blimp/engine/app/blimp_content_browser_client.h
blimp/engine/app/blimp_content_browser_client.cc
blimp/engine/app/blimp_content_browser_manifest_overlay.json
tools/gritsettings/resource_ids
View unified diff
|
Download patch
« blimp/engine/BUILD.gn
('K') |
« blimp/engine/BUILD.gn
('k') |
blimp/engine/app/blimp_content_browser_client.h »
('j') |
blimp/engine/app/blimp_content_browser_client.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<?xml version="1.0" encoding="UTF-8"?>
2
<grit current_release="1" latest_public_release="0" output_all_resource_defines= "false">
3
<outputs>
4
<output filename="grit/blimp_browser_resources.h" type="rc_header">
5
<emit emit_type='prepend'></emit>
6
</output>
7
<output filename="blimp_browser_resources.pak" type="data_package" />
8
</outputs>
9
<release seq="1">
10
<includes>
11
<include name="IDR_BLIMP_CONTENT_BROWSER_MANIFEST_OVERLAY" file="blimp_con tent_browser_manifest_overlay.json" type="BINDATA" />
12
</includes>
13
</release>
14
</grit>
OLD
NEW
« blimp/engine/BUILD.gn
('K') |
« blimp/engine/BUILD.gn
('k') |
blimp/engine/app/blimp_content_browser_client.h »
('j') |
blimp/engine/app/blimp_content_browser_client.cc »
('J')
Issue 2371233002: Blob Channel failed to register service (Closed)
Created 4 years, 2 months ago by Menglin
Modified 4 years, 2 months ago
Reviewers: Ken Rockot(use gerrit already), nyquist, Lei Zhang
Base URL:
Comments: 11
This is Rietveld
408576698