Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Unified Diff: Source/core/rendering/shapes/RasterShape.cpp

Issue 237123002: Fix off-by-one error in RasterShape of CSS shapes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add missing space Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/shapes/RasterShape.cpp
diff --git a/Source/core/rendering/shapes/RasterShape.cpp b/Source/core/rendering/shapes/RasterShape.cpp
index 2caf3ec295ae952d83a2a57a5013db8ae96e0c08..4f2e6fcd94b68aa96e45a06b7b38bebdf28641b5 100644
--- a/Source/core/rendering/shapes/RasterShape.cpp
+++ b/Source/core/rendering/shapes/RasterShape.cpp
@@ -151,7 +151,10 @@ void RasterShape::getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logical
for (int y = y1; y < y2; y++)
excludedInterval.unite(intervals.intervalAt(y));
- result.append(LineSegment(excludedInterval.x1(), excludedInterval.x2() + 1));
+ // Note: |marginIntervals()| returns end-point exclusive
+ // intervals. |excludedInterval.x2()| contains the left-most pixel
+ // offset to the right of the calculated union.
+ result.append(LineSegment(excludedInterval.x1(), excludedInterval.x2()));
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698