chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc - Issue 2371213002: Refactor: Inject StatisticsProvider as a dependency of DeviceCloudPolicyInitializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Issue 2371213002: Refactor: Inject StatisticsProvider as a dependency of DeviceCloudPolicyInitializer. (Closed)

Patch Set: Address Maksim's comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc ('k') | chromeos/system/statistics_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

index 814dc526939b78643ae4a5ecdc8c6705eb100b6d..66d948f9df00af30af1de2f7eeaca0531858ab65 100644

--- a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

@@ -345,6 +345,10 @@ void EnrollmentScreenHandler::ShowEnrollmentStatus(

case policy::EnrollmentStatus::STATUS_ATTRIBUTE_UPDATE_FAILED:

ShowErrorForDevice(IDS_ENTERPRISE_ENROLLMENT_ATTRIBUTE_ERROR, false);

return;

+ case policy::EnrollmentStatus::STATUS_NO_MACHINE_IDENTIFICATION:

+ ShowError(IDS_ENTERPRISE_ENROLLMENT_STATUS_NO_MACHINE_IDENTIFICATION,

+ false);

+ return;

}

NOTREACHED();

}

« no previous file with comments | « chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc ('k') | chromeos/system/statistics_provider.h » ('j') | no next file with comments »