chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc - Issue 2371213002: Refactor: Inject StatisticsProvider as a dependency of DeviceCloudPolicyInitializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Issue 2371213002: Refactor: Inject StatisticsProvider as a dependency of DeviceCloudPolicyInitializer. (Closed)

Patch Set: Address Maksim's comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc ('k') | chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

index 879a91dbf29ea0b86b444d5758877ff98a892de9..21fea22c740707ed423b79ba5a0ae9e9744e7afc 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

@@ -113,7 +113,10 @@ class DeviceCloudPolicyManagerChromeOSTest

state_keys_broker_(&fake_session_manager_client_,

base::ThreadTaskRunnerHandle::Get()),

store_(NULL) {

- fake_statistics_provider_.SetMachineStatistic("serial_numer", "test_sn");

+ fake_statistics_provider_.SetMachineStatistic(

+ chromeos::system::kSerialNumberKey, "test_sn");

+ fake_statistics_provider_.SetMachineStatistic(

+ chromeos::system::kHardwareClassKey, "test_hw");

std::vector<std::string> state_keys;

state_keys.push_back("1");

state_keys.push_back("2");

@@ -207,11 +210,12 @@ class DeviceCloudPolicyManagerChromeOSTest

CreateAttestationFlow());

manager_->Initialize(&local_state_);

manager_->AddDeviceCloudPolicyManagerObserver(this);

- initializer_.reset(new DeviceCloudPolicyInitializer(

+ initializer_ = base::MakeUnique<DeviceCloudPolicyInitializer>(

&local_state_, &device_management_service_,

base::ThreadTaskRunnerHandle::Get(), install_attributes_.get(),

&state_keys_broker_, store_, manager_.get(),

- cryptohome::AsyncMethodCaller::GetInstance(), std::move(unique_flow)));

+ cryptohome::AsyncMethodCaller::GetInstance(), std::move(unique_flow),

+ &fake_statistics_provider_);

initializer_->SetSigningServiceForTesting(

base::MakeUnique<FakeSigningService>());

initializer_->Init();