chromeos/network/network_change_notifier_chromeos_unittest.cc - Issue 23712002: Cleanup network type matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_change_notifier_chromeos_unittest.cc

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added unit tests and rebased. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_change_notifier_chromeos_unittest.cc

diff --git a/chromeos/network/network_change_notifier_chromeos_unittest.cc b/chromeos/network/network_change_notifier_chromeos_unittest.cc

index f8462d80629f613f047a5f3dd571c9c24b9bf262..d2289c9d4ac64b27de8bd5bf652c80c9d9d023cd 100644

--- a/chromeos/network/network_change_notifier_chromeos_unittest.cc

+++ b/chromeos/network/network_change_notifier_chromeos_unittest.cc

@@ -64,6 +64,7 @@ TEST(NetworkChangeNotifierChromeosTest, ConnectionTypeFromShill) {

};

TypeMapping type_mappings[] = {

{ flimflam::kTypeEthernet, "", NetworkChangeNotifier::CONNECTION_ETHERNET },

+ { shill::kTypeEthernetEap, "", NetworkChangeNotifier::CONNECTION_ETHERNET },

{ flimflam::kTypeWifi, "", NetworkChangeNotifier::CONNECTION_WIFI },

{ flimflam::kTypeWimax, "", NetworkChangeNotifier::CONNECTION_4G },

{ "unknown type", "unknown technology",