Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chromeos/network/shill_property_util.h

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit test in Debug. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_ 5 #ifndef CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_
6 #define CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_ 6 #define CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 // Copy configuration properties required by Shill to identify a network. 45 // Copy configuration properties required by Shill to identify a network.
46 // Only WiFi, VPN, Ethernet and EthernetEAP are supported. WiMax and Cellular 46 // Only WiFi, VPN, Ethernet and EthernetEAP are supported. WiMax and Cellular
47 // are not supported. Returns true only if all required properties could be 47 // are not supported. Returns true only if all required properties could be
48 // copied. 48 // copied.
49 bool CopyIdentifyingProperties(const base::DictionaryValue& service_properties, 49 bool CopyIdentifyingProperties(const base::DictionaryValue& service_properties,
50 base::DictionaryValue* dest); 50 base::DictionaryValue* dest);
51 51
52 } // namespace shill_property_util 52 } // namespace shill_property_util
53 53
54 class CHROMEOS_EXPORT NetworkTypePattern {
55 public:
56 // Matches any network.
57 static NetworkTypePattern Default();
58
59 // Matches wireless networks
60 static NetworkTypePattern Wireless();
61
62 // Matches cellular or wimax networks.
63 static NetworkTypePattern Mobile();
64
65 // Matches non virtual networks.
66 static NetworkTypePattern NonVirtual();
67
68 // Matches ethernet networks (with or without EAP).
69 static NetworkTypePattern Ethernet();
70
71 static NetworkTypePattern WiFi();
72 static NetworkTypePattern Cellular();
73 static NetworkTypePattern VPN();
74 static NetworkTypePattern Wimax();
75
76 // Matches only networks of exactly the type |shill_network_type|, which must
77 // be one of the types defined in service_constants.h (e.g.
78 // flimflam::kTypeWifi).
79 // Note: Shill distinguishes Ethernet without EAP from Ethernet with EAP. If
80 // unsure, better use one of the matchers above.
81 static NetworkTypePattern Primitive(const std::string& shill_network_type);
82
83 bool Equals(const NetworkTypePattern& other) const;
84 bool MatchesType(const std::string& shill_network_type) const;
85
86 // Returns true if this pattern matches at least one network type that
87 // |other_pattern| matches (according to MatchesType). Thus MatchesPattern is
88 // symmetric and reflexive but not transitive.
89 // See the unit test for examples.
90 bool MatchesPattern(const NetworkTypePattern& other_pattern) const;
91
92 std::string ToDebugString() const;
93
94 private:
95 explicit NetworkTypePattern(int pattern);
96
97 // The bit array of the matching network types.
98 int pattern_;
99
100 DISALLOW_ASSIGN(NetworkTypePattern);
101 };
102
54 } // namespace chromeos 103 } // namespace chromeos
55 104
56 #endif // CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_ 105 #endif // CHROMEOS_NETWORK_SHILL_PROPERTY_UTIL_H_
OLDNEW
« no previous file with comments | « chromeos/network/shill_property_handler_unittest.cc ('k') | chromeos/network/shill_property_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698