Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/ui/webui/help/help_utils_chromeos.cc

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit test in Debug. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/help/help_utils_chromeos.h" 5 #include "chrome/browser/ui/webui/help/help_utils_chromeos.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/chromeos/settings/cros_settings.h" 11 #include "chrome/browser/chromeos/settings/cros_settings.h"
12 #include "chrome/browser/chromeos/settings/cros_settings_names.h" 12 #include "chrome/browser/chromeos/settings/cros_settings_names.h"
13 #include "chromeos/network/shill_property_util.h"
13 #include "grit/chromium_strings.h" 14 #include "grit/chromium_strings.h"
14 #include "grit/generated_resources.h" 15 #include "grit/generated_resources.h"
15 #include "third_party/cros_system_api/dbus/service_constants.h" 16 #include "third_party/cros_system_api/dbus/service_constants.h"
16 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
17 18
18 namespace { 19 namespace {
19 20
20 const bool kDefaultUpdateOverCellularAllowed = false; 21 const bool kDefaultUpdateOverCellularAllowed = false;
21 22
22 } // namespace 23 } // namespace
(...skipping 17 matching lines...) Expand all
40 LOG(WARNING) << "Can't parse connection type #" << i; 41 LOG(WARNING) << "Can't parse connection type #" << i;
41 continue; 42 continue;
42 } 43 }
43 if (connection_type == 4) 44 if (connection_type == 4)
44 return true; 45 return true;
45 } 46 }
46 return kDefaultUpdateOverCellularAllowed; 47 return kDefaultUpdateOverCellularAllowed;
47 } 48 }
48 49
49 string16 GetConnectionTypeAsUTF16(const std::string& type) { 50 string16 GetConnectionTypeAsUTF16(const std::string& type) {
50 if (type == flimflam::kTypeEthernet) 51 if (chromeos::NetworkTypePattern::Ethernet().MatchesType(type))
51 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_ETHERNET); 52 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_ETHERNET);
52 if (type == flimflam::kTypeWifi) 53 if (type == flimflam::kTypeWifi)
53 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIFI); 54 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIFI);
54 if (type == flimflam::kTypeWimax) 55 if (type == flimflam::kTypeWimax)
55 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIMAX); 56 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIMAX);
56 if (type == flimflam::kTypeBluetooth) 57 if (type == flimflam::kTypeBluetooth)
57 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_BLUETOOTH); 58 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_BLUETOOTH);
58 if (type == flimflam::kTypeCellular) 59 if (type == flimflam::kTypeCellular)
59 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_CELLULAR); 60 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_CELLULAR);
60 if (type == flimflam::kTypeVPN) 61 if (type == flimflam::kTypeVPN)
61 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_VPN); 62 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_VPN);
62 NOTREACHED(); 63 NOTREACHED();
63 return string16(); 64 return string16();
64 } 65 }
65 66
66 } // namespace help_utils_chromeos 67 } // namespace help_utils_chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698