Cleanup network type matching.

chromeos/network/managed_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_MANAGED_STATE_H_
 #define CHROMEOS_NETWORK_MANAGED_STATE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chromeos/chromeos_export.h"
 
 namespace base {
 class Value;
 class DictionaryValue;
 }
 
 namespace chromeos {
 
 class DeviceState;
 class FavoriteState;
 class NetworkState;
 
 // Base class for states managed by NetworkStateManger which are associated
 // with a Shill path (e.g. service path or device path).
-class ManagedState {
+class CHROMEOS_EXPORT ManagedState {
  public:
   enum ManagedType {
     MANAGED_TYPE_NETWORK,
     MANAGED_TYPE_FAVORITE,
     MANAGED_TYPE_DEVICE
   };
 
   virtual ~ManagedState();
 
   // This will construct and return a new instance of the appropriate class
@@ skipping 29 matching lines @@
   const std::string& path() const { return path_; }
   const std::string& name() const { return name_; }
   const std::string& type() const { return type_; }
   bool update_received() const { return update_received_; }
   void set_update_received() { update_received_ = true; }
   bool update_requested() const { return update_requested_; }
   void set_update_requested(bool update_requested) {
     update_requested_ = update_requested;
   }
 
+  // Returns true if the network's |type()| is ethernet (with or without EAP).
+  bool IsTypeEthernet() const;

[stevenjb, 2013/08/28 15:51:30]

This should really be IsTypeWired() and we should add Wireless and Mobile also,
or just use shill_property_util helper methods directly.

Now that I think about it, maybe TypeEthernet is better than TypeWired, but we
should be consistent one way or the other.

[pneubeck (no reviews), 2013/09/02 20:41:21]

Done.

+
  protected:
   ManagedState(ManagedType type, const std::string& path);
 
   // Parses common property keys (name, type).
   bool ManagedStatePropertyChanged(const std::string& key,
                                    const base::Value& value);
 
   // Helper methods that log warnings and return true if parsing succeeded and
   // the new value does not match the existing output value.
   bool GetBooleanValue(const std::string& key,
@@ skipping 28 matching lines @@
 
   // Tracks when an update has been requested.
   bool update_requested_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagedState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_MANAGED_STATE_H_