Cleanup network type matching.

chrome/browser/ui/webui/help/help_utils_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_utils_chromeos.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/values.h"
@@ skipping 29 matching lines @@
       LOG(WARNING) << "Can't parse connection type #" << i;
       continue;
     }
     if (connection_type == 4)
       return true;
   }
   return kDefaultUpdateOverCellularAllowed;
 }
 
 string16 GetConnectionTypeAsUTF16(const std::string& type) {
-  if (type == flimflam::kTypeEthernet)
+  if (type == flimflam::kTypeEthernet || type == shill::kTypeEthernetEap)

[stevenjb, 2013/08/28 15:51:30]

This is where having a method like shill_property_utill::IsTypeWired(type) would
be helpful.

ash::network_util would be a good namespace / location for this and other helper
methods (maybe in a follow-up CL).

[pneubeck (no reviews), 2013/09/02 20:41:21]

Done.

     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_ETHERNET);
   if (type == flimflam::kTypeWifi)
     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIFI);
   if (type == flimflam::kTypeWimax)
     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIMAX);
   if (type == flimflam::kTypeBluetooth)
     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_BLUETOOTH);
   if (type == flimflam::kTypeCellular)
     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_CELLULAR);
   if (type == flimflam::kTypeVPN)
     return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_VPN);
   NOTREACHED();
   return string16();
 }
 
 }  // namespace help_utils_chromeos