Cleanup network type matching.

chrome/browser/extensions/api/dial/dial_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/dial/dial_service.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
@@ skipping 171 matching lines @@
 #else
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, base::Bind(
       &GetNetworkListOnFileThread,
       base::MessageLoopProxy::current(), base::Bind(
           &DialServiceImpl::SendNetworkList, AsWeakPtr())));
 #endif
 }
 
 #if defined(OS_CHROMEOS)
 IPAddressNumber DialServiceImpl::GetBestBindAddressChromeOS() {
-  std::string connection_types[] =
-      {flimflam::kTypeWifi, flimflam::kTypeEthernet};
+  std::string connection_types[] = {
+      flimflam::kTypeWifi, chromeos::NetworkStateHandler::kMatchTypeWired};
   for (uint i = 0; i < arraysize(connection_types); ++i) {

[stevenjb, 2013/08/28 15:51:30]

I find this confusing. Can we move the logic below to a helper method and call
it explicitly for Wifi and Wired? It also seems strange to me that we would
check wifi before wired, do you know why that is, and if so can you add a
comment? If not, maybe investigate?

[pneubeck (no reviews), 2013/09/02 20:41:21]

I will add the author as reviewer.

     IPAddressNumber bind_ip_address;
     const chromeos::NetworkState* state =
         chromeos::NetworkHandler::Get()->network_state_handler()->
             ConnectedNetworkByType(connection_types[i]);
     if (state &&
         net::ParseIPLiteralToNumber(state->ip_address(), &bind_ip_address)) {
       DCHECK(bind_ip_address.size() == net::kIPv4AddressSize);
       DVLOG(1) << "Found " << state->type() << ", " << state->name() << ":"
                << state->ip_address();
       return bind_ip_address;
@@ skipping 272 matching lines @@
     DVLOG(0) << "dial socket error: " << error_str;
     // TODO(justinlin): More granular socket errors.
     FOR_EACH_OBSERVER(
         Observer, observer_list_, OnError(this, DIAL_SERVICE_SOCKET_ERROR));
     return false;
   }
   return true;
 }
 
 }  // namespace extensions