Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: chrome/browser/chromeos/status/network_menu.cc

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/status/network_menu.h" 5 #include "chrome/browser/chromeos/status/network_menu.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/shell_delegate.h" 10 #include "ash/shell_delegate.h"
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 void MainMenuModel::InitMenuItems(bool should_open_button_options) { 378 void MainMenuModel::InitMenuItems(bool should_open_button_options) {
379 menu_items_.clear(); 379 menu_items_.clear();
380 380
381 NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler(); 381 NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
382 382
383 // Populate our MenuItems with the current list of networks. 383 // Populate our MenuItems with the current list of networks.
384 string16 label; 384 string16 label;
385 385
386 // Ethernet 386 // Ethernet
387 // Only display an ethernet icon if enabled, and an ethernet network exists. 387 // Only display an ethernet icon if enabled, and an ethernet network exists.
388 bool ethernet_enabled = handler->IsTechnologyEnabled(flimflam::kTypeEthernet); 388 bool ethernet_enabled =
389 handler->IsTechnologyEnabled(NetworkStateHandler::kMatchTypeWired);
389 const NetworkState* ethernet_network = 390 const NetworkState* ethernet_network =
390 handler->FirstNetworkByType(flimflam::kTypeEthernet); 391 handler->FirstNetworkByType(NetworkStateHandler::kMatchTypeWired);
391 if (ethernet_enabled && ethernet_network) { 392 if (ethernet_enabled && ethernet_network) {
392 bool ethernet_connecting = ethernet_network->IsConnectingState(); 393 bool ethernet_connecting = ethernet_network->IsConnectingState();
393 if (ethernet_connecting) { 394 if (ethernet_connecting) {
394 label = l10n_util::GetStringFUTF16( 395 label = l10n_util::GetStringFUTF16(
395 IDS_STATUSBAR_NETWORK_DEVICE_STATUS, 396 IDS_STATUSBAR_NETWORK_DEVICE_STATUS,
396 l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET), 397 l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET),
397 l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_CONNECTING)); 398 l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_CONNECTING));
398 } else { 399 } else {
399 label = l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET); 400 label = l10n_util::GetStringUTF16(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
400 } 401 }
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 612
612 if (default_network) { 613 if (default_network) {
613 std::string ip_address = default_network->ip_address(); 614 std::string ip_address = default_network->ip_address();
614 if (!ip_address.empty()) { 615 if (!ip_address.empty()) {
615 address_items.push_back(MenuItem(ui::MenuModel::TYPE_COMMAND, 616 address_items.push_back(MenuItem(ui::MenuModel::TYPE_COMMAND,
616 ASCIIToUTF16(ip_address), gfx::ImageSkia(), std::string(), 617 ASCIIToUTF16(ip_address), gfx::ImageSkia(), std::string(),
617 FLAG_DISABLED)); 618 FLAG_DISABLED));
618 } 619 }
619 } 620 }
620 621
621 std::string ethernet_address = 622 std::string ethernet_address = handler->FormattedHardwareAddressForType(
622 handler->FormattedHardwareAddressForType(flimflam::kTypeEthernet); 623 NetworkStateHandler::kMatchTypeWired);
623 if (!ethernet_address.empty()) { 624 if (!ethernet_address.empty()) {
624 std::string label = l10n_util::GetStringUTF8( 625 std::string label = l10n_util::GetStringUTF8(
625 IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET) + " " + ethernet_address; 626 IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET) + " " + ethernet_address;
626 address_items.push_back(MenuItem( 627 address_items.push_back(MenuItem(
627 ui::MenuModel::TYPE_COMMAND, 628 ui::MenuModel::TYPE_COMMAND,
628 UTF8ToUTF16(label), gfx::ImageSkia(), std::string(), FLAG_DISABLED)); 629 UTF8ToUTF16(label), gfx::ImageSkia(), std::string(), FLAG_DISABLED));
629 } 630 }
630 631
631 std::string wifi_address = 632 std::string wifi_address =
632 handler->FormattedHardwareAddressForType(flimflam::kTypeWifi); 633 handler->FormattedHardwareAddressForType(flimflam::kTypeWifi);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 return main_menu_model_.get(); 670 return main_menu_model_.get();
670 } 671 }
671 672
672 void NetworkMenu::UpdateMenu() { 673 void NetworkMenu::UpdateMenu() {
673 refreshing_menu_ = true; 674 refreshing_menu_ = true;
674 main_menu_model_->InitMenuItems(delegate_->ShouldOpenButtonOptions()); 675 main_menu_model_->InitMenuItems(delegate_->ShouldOpenButtonOptions());
675 refreshing_menu_ = false; 676 refreshing_menu_ = false;
676 } 677 }
677 678
678 } // namespace chromeos 679 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698