Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: chrome/browser/chromeos/prerender_condition_network.cc

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/prerender_condition_network.h" 5 #include "chrome/browser/chromeos/prerender_condition_network.h"
6 6
7 #include "chromeos/network/network_state.h" 7 #include "chromeos/network/network_state.h"
8 #include "chromeos/network/network_state_handler.h" 8 #include "chromeos/network/network_state_handler.h"
9 #include "third_party/cros_system_api/dbus/service_constants.h" 9 #include "third_party/cros_system_api/dbus/service_constants.h"
10 10
11 namespace chromeos { 11 namespace chromeos {
12 12
13 PrerenderConditionNetwork::PrerenderConditionNetwork() { 13 PrerenderConditionNetwork::PrerenderConditionNetwork() {
14 } 14 }
15 15
16 PrerenderConditionNetwork::~PrerenderConditionNetwork() { 16 PrerenderConditionNetwork::~PrerenderConditionNetwork() {
17 } 17 }
18 18
19 bool PrerenderConditionNetwork::CanPrerender() const { 19 bool PrerenderConditionNetwork::CanPrerender() const {
20 const NetworkState* default_network = 20 const NetworkState* default_network =
21 NetworkHandler::Get()->network_state_handler()->DefaultNetwork(); 21 NetworkHandler::Get()->network_state_handler()->DefaultNetwork();
22 if (!default_network) 22 if (!default_network)
23 return false; 23 return false;
24 const std::string& type = default_network->type(); 24 const std::string& type = default_network->type();
25 if (type == flimflam::kTypeEthernet || type == flimflam::kTypeWifi) 25 if (default_network->IsTypeEthernet() || type == flimflam::kTypeWifi)
stevenjb 2013/08/28 15:51:30 I think this should probably be !default_network->
pneubeck (no reviews) 2013/09/02 20:41:21 Done.
26 return true; 26 return true;
27 return false; 27 return false;
28 } 28 }
29 29
30 } // namespace chromeos 30 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698