Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/browser/chromeos/login/proxy_settings_dialog.cc

Issue 23712002: Cleanup network type matching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/proxy_settings_dialog.h" 5 #include "chrome/browser/chromeos/login/proxy_settings_dialog.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/chromeos/login/helper.h" 10 #include "chrome/browser/chromeos/login/helper.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 : LoginWebDialog(delegate, 56 : LoginWebDialog(delegate,
57 window, 57 window,
58 string16(), 58 string16(),
59 GetURLForProxySettings(network.path()), 59 GetURLForProxySettings(network.path()),
60 LoginWebDialog::STYLE_BUBBLE) { 60 LoginWebDialog::STYLE_BUBBLE) {
61 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 61 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
62 ++instance_count_; 62 ++instance_count_;
63 63
64 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size())); 64 gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));
65 SetDialogSize(CalculateSize(screen_bounds.width(), 65 SetDialogSize(CalculateSize(screen_bounds.width(),
66 kProxySettingsDialogReasonableWidth, 66 kProxySettingsDialogReasonableWidth,
67 kProxySettingsDialogReasonableWidthRatio), 67 kProxySettingsDialogReasonableWidthRatio),
68 CalculateSize(screen_bounds.height(), 68 CalculateSize(screen_bounds.height(),
69 kProxySettingsDialogReasonableHeight, 69 kProxySettingsDialogReasonableHeight,
70 kProxySettingsDialogReasonableHeightRatio)); 70 kProxySettingsDialogReasonableHeightRatio));
71 71
72 std::string network_name = network.name(); 72 std::string network_name = network.name();
73 if (network_name.empty() && network.type() == flimflam::kTypeEthernet) { 73 if (network_name.empty() && network.IsTypeEthernet()) {
74 network_name = 74 network_name =
75 l10n_util::GetStringUTF8(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET); 75 l10n_util::GetStringUTF8(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
76 } 76 }
77 77
78 SetDialogTitle(l10n_util::GetStringFUTF16(IDS_PROXY_PAGE_TITLE_FORMAT, 78 SetDialogTitle(l10n_util::GetStringFUTF16(IDS_PROXY_PAGE_TITLE_FORMAT,
79 ASCIIToUTF16(network_name))); 79 ASCIIToUTF16(network_name)));
80 } 80 }
81 81
82 ProxySettingsDialog::~ProxySettingsDialog() { 82 ProxySettingsDialog::~ProxySettingsDialog() {
83 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 83 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
84 --instance_count_; 84 --instance_count_;
85 } 85 }
86 86
87 void ProxySettingsDialog::OnDialogClosed(const std::string& json_retval) { 87 void ProxySettingsDialog::OnDialogClosed(const std::string& json_retval) {
88 LoginWebDialog::OnDialogClosed(json_retval); 88 LoginWebDialog::OnDialogClosed(json_retval);
89 content::NotificationService::current()->Notify( 89 content::NotificationService::current()->Notify(
90 chrome::NOTIFICATION_LOGIN_PROXY_CHANGED, 90 chrome::NOTIFICATION_LOGIN_PROXY_CHANGED,
91 content::NotificationService::AllSources(), 91 content::NotificationService::AllSources(),
92 content::NotificationService::NoDetails()); 92 content::NotificationService::NoDetails());
93 } 93 }
94 94
95 bool ProxySettingsDialog::IsShown() { 95 bool ProxySettingsDialog::IsShown() {
96 return instance_count_ > 0; 96 return instance_count_ > 0;
97 } 97 }
98 98
99 } // namespace chromeos 99 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698