Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2371173002: [heap] Cleanup Heap::SetUp (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup Heap::SetUp BUG= Committed: https://crrev.com/263c20d36ce7050d7ab45291ac8a82926c637b20 Cr-Commit-Position: refs/heads/master@{#39785}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M src/heap/heap.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Michael Lippautz
4 years, 2 months ago (2016-09-27 14:13:37 UTC) #2
ulan
lgtm
4 years, 2 months ago (2016-09-27 14:14:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371173002/1
4 years, 2 months ago (2016-09-27 16:26:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25136)
4 years, 2 months ago (2016-09-27 16:29:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371173002/20001
4 years, 2 months ago (2016-09-27 16:36:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 17:06:29 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:06:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/263c20d36ce7050d7ab45291ac8a82926c637b20
Cr-Commit-Position: refs/heads/master@{#39785}

Powered by Google App Engine
This is Rietveld 408576698