|
|
Chromium Code Reviews
DescriptionSet status bar height to 44px on login screen
The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen.
BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
Committed: https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3
Cr-Commit-Position: refs/heads/master@{#423461}
Patch Set 1 #
Messages
Total messages: 27 (17 generated)
Description was changed from ========== . BUG= ========== to ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== . BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== . BUG= ========== to ========== Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode ==========
yoshiki@chromium.org changed reviewers: + achuith@chromium.org
Achuith, PTAL. Thanks.
can you ask Omri if this change is ok? lgtm from me.
yoshiki@chromium.org changed reviewers: + omrilio@chromium.org
omrilio@, PTAL
omrilio@, ping
On 2016/10/05 19:09:12, yoshiki wrote: > omrilio@, ping You might try catching him on chat, or in person, and providing screenshots of the differences if that's possible?
lgtm Sorry about the delay, Looks good!
Thanks!
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode ========== to ========== Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode ========== to ========== Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode Committed: https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3 Cr-Commit-Position: refs/heads/master@{#423461} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3 Cr-Commit-Position: refs/heads/master@{#423461} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
