Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2371153002: Set status bar height to 44px on login screen (Closed)

Created:
4 years, 2 months ago by yoshiki
Modified:
4 years, 2 months ago
Reviewers:
achuithb, omrilio
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set status bar height to 44px on login screen The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen. BUG=641377 TEST=see the notification tray manually with MD and non-MD mode Committed: https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3 Cr-Commit-Position: refs/heads/master@{#423461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
yoshiki
Achuith, PTAL. Thanks.
4 years, 2 months ago (2016-09-30 21:59:36 UTC) #14
achuithb
can you ask Omri if this change is ok? lgtm from me.
4 years, 2 months ago (2016-09-30 22:02:40 UTC) #15
yoshiki
omrilio@, PTAL
4 years, 2 months ago (2016-10-03 07:59:20 UTC) #17
yoshiki
omrilio@, ping
4 years, 2 months ago (2016-10-05 19:09:12 UTC) #18
achuithb
On 2016/10/05 19:09:12, yoshiki wrote: > omrilio@, ping You might try catching him on chat, ...
4 years, 2 months ago (2016-10-05 21:25:30 UTC) #19
omrilio
lgtm Sorry about the delay, Looks good!
4 years, 2 months ago (2016-10-06 03:47:08 UTC) #20
yoshiki
Thanks!
4 years, 2 months ago (2016-10-06 05:55:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371153002/20001
4 years, 2 months ago (2016-10-06 05:56:03 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-06 07:01:40 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 07:04:40 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9699d3ee0cea558cb2f71669240355cbc9d723a3
Cr-Commit-Position: refs/heads/master@{#423461}

Powered by Google App Engine
This is Rietveld 408576698