Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2371143002: another attempt to fix nonrectangular (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

another attempt to fix nonrectangular For hairlines extended by the end cap, set the first point to the first curve following a move, which has had its position adjusted. R=fmalita@chromium.org BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371143002 Committed: https://skia.googlesource.com/skia/+/67075f0723f7ac5a7822b8d5708357b36224f0bf

Patch Set 1 #

Patch Set 2 : change first only if prior is curve #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/core/SkScan_Hairline.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
caryclark
4 years, 2 months ago (2016-09-27 14:35:54 UTC) #8
f(malita)
lgtm
4 years, 2 months ago (2016-09-27 14:45:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371143002/20001
4 years, 2 months ago (2016-09-27 15:40:18 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 15:41:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/67075f0723f7ac5a7822b8d5708357b36224f0bf

Powered by Google App Engine
This is Rietveld 408576698