Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 2371133004: Omit unreachable fall through code for graph intrinsics, e.g. Array.length. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index e668652800e57bd2b4e06f7f0cceb8cab3df0a59..0d4fdf38ed7225d4038b04c4d6e63aebff34e9bf 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -1172,9 +1172,10 @@ bool FlowGraphCompiler::TryIntrinsify() {
EnterIntrinsicMode();
- Intrinsifier::Intrinsify(parsed_function(), this);
+ bool complete = Intrinsifier::Intrinsify(parsed_function(), this);
ExitIntrinsicMode();
+
// "Deoptimization" from intrinsic continues here. All deoptimization
// branches from intrinsic code redirect to here where the slow-path
// (normal function body) starts.
@@ -1182,7 +1183,7 @@ bool FlowGraphCompiler::TryIntrinsify() {
// before any deoptimization point.
ASSERT(!intrinsic_slow_path_label_.IsBound());
assembler()->Bind(&intrinsic_slow_path_label_);
- return false;
+ return complete;
}
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698