Issue 2371133004: Omit unreachable fall through code for graph intrinsics, e.g. Array.length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2371133004: Omit unreachable fall through code for graph intrinsics, e.g. Array.length. (Closed)

Created:
4 years, 2 months ago by rmacnak

Modified:
4 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -6 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 2 months ago (2016-09-28 23:38:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
82ec8d6c9e37ef74d36f0bbc651b2f872e6de903 (presubmit successful).