third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js - Issue 2371133003: [Devtools] Lazily build reverse mappings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 2371133003: [Devtools] Lazily build reverse mappings (Closed)

Patch Set: Comments were addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

index c020981eb12fc8325641333040c703cff424eedc..9676f9360c0d2980463cb6edb445a0e50d10c416 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

@@ -97,7 +97,7 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {

var snippetStartIndex = columnNumber > 100 ? columnNumber : 0;

snippetElement.textContent = lineText.substr(snippetStartIndex).trimEnd(maxSnippetLength);

}

- this.didReceiveBreakpointLineForTest(uiLocation.uiSourceCode);

+ this.didReceiveBreakpointLineForTest(uiLocation.uiSourceCode, lineNumber, columnNumber);

}

uiLocation.uiSourceCode.requestContent().then(didRequestContent.bind(this));

@@ -117,8 +117,10 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {

/**

* @param {!WebInspector.UISourceCode} uiSourceCode

+ * @param {number} lineNumber

+ * @param {number} columnNumber

- didReceiveBreakpointLineForTest: function(uiSourceCode)

+ didReceiveBreakpointLineForTest: function(uiSourceCode, lineNumber, columnNumber)

{