Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2371133003: [Devtools] Lazily build reverse mappings (Closed)
Patch Set: Comments were addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
index e24342f8afa8a1bbff2232faf7b4b0ed7845044b..d2c3e8ff4fcb04e7a16d49266f456ba9621dc1bd 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
@@ -149,14 +149,14 @@ WebInspector.BlackboxManager.prototype = {
if (!previousScriptState)
return Promise.resolve();
- var mappings = sourceMap.mappings().slice();
- mappings.sort(mappingComparator);
-
+ var hasBlackboxedMappings = sourceMap.sourceURLs().some((url) => this.isBlackboxedURL(url));
+ var mappings = hasBlackboxedMappings ? sourceMap.mappings().slice() : [];
if (!mappings.length) {
lushnikov 2016/10/01 04:23:50 how's a sourceMap with empty mappings differs from
kozy 2016/10/01 04:40:21 There are no big difference between empty source m
if (previousScriptState.length > 0)
return this._setScriptState(script, []);
return Promise.resolve();
}
+ mappings.sort(mappingComparator);
var currentBlackboxed = false;
var isBlackboxed = false;

Powered by Google App Engine
This is Rietveld 408576698