Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html

Issue 2371133003: [Devtools] Lazily build reverse mappings (Closed)
Patch Set: Addressing comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
index b53c64b28a4a6cca1c3cc411023efcd94119f44a..ca8ad0aa6165c1a7512fe009b3a155c86a1bd7b5 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
@@ -41,16 +41,18 @@ var test = function()
function waitForBreakpoints()
{
- var breakpointAddCounter = 4; // Before source map loaded and after.
+ var expectedBreakpointLocations = [[14, 0], [16, 4]];
var jsBreakpoints = self.runtime.sharedInstance(WebInspector.JavaScriptBreakpointsSidebarPane);
- jsBreakpoints.didReceiveBreakpointLineForTest = function(uiSourceCode)
+ jsBreakpoints.didReceiveBreakpointLineForTest = function(uiSourceCode, line, column)
{
if (WebInspector.CompilerScriptMapping.StubProjectID === uiSourceCode.project().id())
return;
if (!uiSourceCode.url().endsWith("source1.js"))
return;
- --breakpointAddCounter;
- if (breakpointAddCounter)
+
+ expectedBreakpointLocations =
+ expectedBreakpointLocations.filter((location) => (location[0] != line && location[1] != column));
+ if (expectedBreakpointLocations.length)
return;
breakpointSourcesReceived = true;
maybeCompleteTest();

Powered by Google App Engine
This is Rietveld 408576698