Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2371133002: [heap] Make committed counters on space size_t (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make committed counters on space size_t BUG= Committed: https://crrev.com/6d32126cb71fc2c97751e001358b56b29e08b725 Cr-Commit-Position: refs/heads/master@{#39811}

Patch Set 1 #

Patch Set 2 : Remove SizeAsInt... #

Patch Set 3 : More Committed* methods changed to size_t #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -50 lines) Patch
M src/extensions/statistics-extension.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 5 chunks +13 lines, -16 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 5 chunks +10 lines, -16 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Michael Lippautz
4 years, 2 months ago (2016-09-27 12:30:54 UTC) #3
Hannes Payer (out of office)
lgtm
4 years, 2 months ago (2016-09-27 18:07:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371133002/40001
4 years, 2 months ago (2016-09-27 18:29:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25156)
4 years, 2 months ago (2016-09-27 18:33:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371133002/60001
4 years, 2 months ago (2016-09-28 08:45:07 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-28 08:48:28 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 08:48:45 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6d32126cb71fc2c97751e001358b56b29e08b725
Cr-Commit-Position: refs/heads/master@{#39811}

Powered by Google App Engine
This is Rietveld 408576698