Use .packages instead of pubspec.yaml

Use .packages instead of pubspec.yaml

This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/68d2121fd0e26f20067bd5ff0d0f8e79d90d84bc

[vsm, 2016-09-28 00:08:50]

Description was changed from

==========
Use .packages instead of pubspec.yaml

This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.
==========

to

==========
Use .packages instead of pubspec.yaml

This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204
==========

[vsm, 2016-09-28 00:08:50]

vsm@google.com changed reviewers:
+ jmesserly@google.com, rnystrom@google.com

[vsm, 2016-09-28 15:41:06]

On 2016/09/28 00:08:56, vsm wrote:

PTAL

It's going green.  And the SDK builder env's are back in business as well.

https://travis-ci.org/dart-lang/sdk/builds/163438485

[vsm, 2016-09-28 15:42:19]

https://codereview.chromium.org/2371113004/diff/40001/.travis.yml
File .travis.yml (right):

https://codereview.chromium.org/2371113004/diff/40001/.travis.yml#newcode61
.travis.yml:61: - rm -f .packages
Note, I'm doing these steps basic the dart-travis setup does a 'pub get'.

kevmoo suggests that this can be suppressed via an empty install step.  will try
that.

[Bob Nystrom, 2016-09-28 16:02:47]

LGTM, though I don't pretend to have much understanding of a lot of this.

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:54: this.packageRoot: null,
You should be able to just omit this argument, right? Or does AnalyzerOptions
have a different default value than null for packageRoot?

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/pubspe...
File pkg/dev_compiler/pubspec.yaml (right):

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/pubspe...
pkg/dev_compiler/pubspec.yaml:9: 
It would be good to leave a comment here explaining why there are no
dependencies.

[vsm, 2016-09-28 16:10:04]

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:54: this.packageRoot: null,
On 2016/09/28 16:02:47, Bob Nystrom wrote:
> You should be able to just omit this argument, right? Or does AnalyzerOptions
> have a different default value than null for packageRoot?

Good point.  Looking into whether I can just remove the option altogether.  Not
sure if it's used anywhere.

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/pubspe...
File pkg/dev_compiler/pubspec.yaml (right):

https://codereview.chromium.org/2371113004/diff/40001/pkg/dev_compiler/pubspe...
pkg/dev_compiler/pubspec.yaml:9: 
On 2016/09/28 16:02:47, Bob Nystrom wrote:
> It would be good to leave a comment here explaining why there are no
> dependencies.

Note - per kevmoo's suggestion, I was able to delete this file.  See latest.

[Jennifer Messerly, 2016-09-28 16:33:56]

lgtm

https://codereview.chromium.org/2371113004/diff/60001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2371113004/diff/60001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:54: this.packageRoot: null,
style nit: "null" is not needed

https://codereview.chromium.org/2371113004/diff/60001/pkg/dev_compiler/test/b...
File pkg/dev_compiler/test/browser/language_tests.js (right):

https://codereview.chromium.org/2371113004/diff/60001/pkg/dev_compiler/test/b...
pkg/dev_compiler/test/browser/language_tests.js:575:
'constructor_calls_created_synchronously_test': ['unittest', 'skip', 'fail'],
long line

[vsm, 2016-09-28 16:49:42]

Description was changed from

==========
Use .packages instead of pubspec.yaml

This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204
==========

to

==========
Use .packages instead of pubspec.yaml

This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/68d2121fd0e26f20067bd5ff0d0f8e79d90d84bc
==========

[vsm, 2016-09-28 16:49:43]

Committed patchset #6 (id:100001) manually as
68d2121fd0e26f20067bd5ff0d0f8e79d90d84bc (presubmit successful).