ui/views/view_targeter_unittest.cc - Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view_targeter_unittest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)

Patch Set: add ClearNativeFocus() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/view_targeter_unittest.cc

diff --git a/ui/views/view_targeter_unittest.cc b/ui/views/view_targeter_unittest.cc

index 620cfea3601ebddc959c3732367eb9547a55fd1b..0780ecc041ca3f781a3c6ed0f8ac20872e31399d 100644

--- a/ui/views/view_targeter_unittest.cc

+++ b/ui/views/view_targeter_unittest.cc

@@ -122,9 +122,10 @@ gfx::Rect ConvertRectFromWidgetToView(View* view, const gfx::Rect& r) {

TEST_F(ViewTargeterTest, ViewTargeterForKeyEvents) {

Widget widget;

Widget::InitParams init_params =

- CreateParams(Widget::InitParams::TYPE_POPUP);

+ CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);

init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

widget.Init(init_params);

+ widget.Show();

View* content = new View;

View* child = new View;