ui/views/focus/focus_manager_unittest.cc - Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/focus/focus_manager_unittest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)

Patch Set: add ClearNativeFocus() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/focus/focus_manager_unittest.cc

diff --git a/ui/views/focus/focus_manager_unittest.cc b/ui/views/focus/focus_manager_unittest.cc

index a655eafcc45e0c3d37abf43989a3f78704fc6db0..8d846e6c471e9e995e1f46e11aa6efdb76d25c98 100644

--- a/ui/views/focus/focus_manager_unittest.cc

+++ b/ui/views/focus/focus_manager_unittest.cc

@@ -878,7 +878,7 @@ TEST_F(FocusManagerTest, AdvanceFocusStaysInWidget) {

view2->SetBounds(20, 0, 20, 20);

child_widget.client_view()->AddChildView(view1);

child_widget.client_view()->AddChildView(view2);

- child_widget.Show();

+ GetWidget()->Show();

view2->RequestFocus();

EXPECT_EQ(view2, GetFocusManager()->GetFocusedView());