Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)
Patch Set: new patch Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
index 5d1cfcf59e682b0dfc9a61f5f1c6783a9388397b..5b23a659170007c855d8231eaaa0834a81970b73 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
@@ -35,6 +35,7 @@
#include "chrome/common/extensions/api/downloads.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/browser_context.h"
@@ -472,6 +473,7 @@ class DownloadExtensionTest : public ExtensionApiTest {
if (manager->InProgressCount() != 0)
return NULL;
+ EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(current_browser()));
sky 2016/09/28 21:56:53 Why is this necessary? In process browser tests al
Qiang(Joe) Xu 2016/09/29 00:07:25 These two browser_tests are both related to more t
ui_test_utils::NavigateToURL(current_browser(), slow_download_url);
observer->WaitForFinished();
« no previous file with comments | « ash/common/system/tray/tray_details_view_unittest.cc ('k') | chrome/browser/geolocation/geolocation_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698