chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc - Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc

Issue 2371113003: Do not give instant focus if a view's toplevelwidget is not active (Closed)

Patch Set: replace ClearNativeFocus with widget_->Activate() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc » ('j') | ui/views/focus/focus_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc

index abf2dbb18e202d6ba5779058c062e5bd67ea5b66..c4a97152863bc446c18038aba5895b8b436948e7 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc

@@ -45,6 +45,7 @@ class AppInfoDialogAshTest : public ash::test::AshTestBase {

widget_->GetNativeWindow(), extension_environment_.profile(),

extension_environment_.MakePackagedApp(kTestExtensionId, true).get());

widget_->GetContentsView()->AddChildView(dialog_);

+ widget_->Show();

}

void TearDown() override {