Do not give instant focus if a view's toplevelwidget is not active

ui/views/widget/native_widget_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/env.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
+#include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/base_focus_rules.h"
 #include "ui/wm/core/default_activation_client.h"
 #include "ui/wm/core/focus_controller.h"
 
 namespace views {
 namespace {
@@ skipping 111 matching lines @@
   params.show_state = ui::SHOW_STATE_MINIMIZED;
   params.bounds.SetRect(0, 0, 1024, 800);
   std::unique_ptr<Widget> widget(new Widget());
   widget->Init(params);
   widget->Show();
 
   EXPECT_TRUE(widget->IsMinimized());
   widget->CloseNow();
 }
 
+TEST_F(NativeWidgetAuraTest, NonActiveWindowRequestImeFocus) {
+  Widget::InitParams params(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.parent = nullptr;
+  params.context = root_window();
+
+  std::unique_ptr<Widget> widget1(new Widget());
+  widget1->Init(params);
+  Textfield* textfield1 = new Textfield();
+  widget1->GetRootView()->AddChildView(textfield1);
+  Textfield* textfield2 = new Textfield();
+  widget1->GetRootView()->AddChildView(textfield2);
+
+  std::unique_ptr<Widget> widget2(new Widget());
+  widget2->Init(params);
+  Textfield* textfield3 = new Textfield();
+  widget2->GetRootView()->AddChildView(textfield3);
+
+  // |widget1| non-active, |widget2| active. |widget1|'s child view
+  // should not be able to get IME focus.
+  widget2->Activate();
+  EXPECT_FALSE(widget1->IsActive());
+  EXPECT_TRUE(widget2->IsActive());
+  textfield3->RequestFocus();
+  EXPECT_TRUE(textfield3->HasFocus());
+  EXPECT_FALSE(textfield1->HasFocus());
+  EXPECT_FALSE(textfield2->HasFocus());
+  textfield1->RequestFocus();
+  EXPECT_TRUE(textfield3->HasFocus());
+  EXPECT_FALSE(textfield1->HasFocus());
+  EXPECT_FALSE(textfield2->HasFocus());
+
+  // |widget1| becomes active. Since |textfield1| requests focus when |widget1|
+  // is non-active, the focus is stored and will be set when |widget1|
+  // is activated.
+  widget1->Activate();
+  EXPECT_TRUE(widget1->IsActive());
+  EXPECT_FALSE(widget2->IsActive());
+  EXPECT_TRUE(textfield1->HasFocus());
+  EXPECT_FALSE(textfield2->HasFocus());
+  EXPECT_FALSE(textfield3->HasFocus());
+}
+
 // A WindowObserver that counts kShowStateKey property changes.
 class TestWindowObserver : public aura::WindowObserver {
  public:
   explicit TestWindowObserver(gfx::NativeWindow window) : window_(window) {
     window_->AddObserver(this);
   }
   ~TestWindowObserver() override {
     window_->RemoveObserver(this);
   }
 
@@ skipping 433 matching lines @@
   EXPECT_FALSE(delegate.view()->HasFocus());
 
   test_focus_rules()->set_can_activate(true);
   views::test::TestInitialFocusWidgetDelegate delegate2(root_window());
   delegate2.GetWidget()->Show();
   EXPECT_TRUE(delegate2.view()->HasFocus());
 }
 
 }  // namespace
 }  // namespace views