Do not give instant focus if a view's toplevelwidget is not active

ui/views/widget/native_widget_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/env.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
+#include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/base_focus_rules.h"
 #include "ui/wm/core/default_activation_client.h"
 #include "ui/wm/core/focus_controller.h"
 
 namespace views {
 namespace {
@@ skipping 111 matching lines @@
   params.show_state = ui::SHOW_STATE_MINIMIZED;
   params.bounds.SetRect(0, 0, 1024, 800);
   std::unique_ptr<Widget> widget(new Widget());
   widget->Init(params);
   widget->Show();
 
   EXPECT_TRUE(widget->IsMinimized());
   widget->CloseNow();
 }
 
+TEST_F(NativeWidgetAuraTest, NonActiveWindowRequestImeFocus) {
+  Widget::InitParams params(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.parent = nullptr;
+  params.context = root_window();
+
+  // |widget1| sets to non-activatable.
+  std::unique_ptr<Widget> widget1(new Widget());

[sky, 2016/10/13 16:21:21]

widget1 and widget2 can be defined on the stack (no need to wrap in unique_ptr).

[Qiang(Joe) Xu, 2016/10/14 01:42:39]

Done.

+  widget1->Init(params);
+  widget1->widget_delegate()->set_can_activate(false);
+  Textfield* textfield0 = new Textfield();
+  widget1->GetRootView()->AddChildView(textfield0);
+  Textfield* textfield1 = new Textfield();
+  widget1->GetRootView()->AddChildView(textfield1);
+
+  std::unique_ptr<Widget> widget2(new Widget());
+  widget2->Init(params);
+  Textfield* textfield2 = new Textfield();
+  widget2->GetRootView()->AddChildView(textfield2);
+
+  textfield2->RequestFocus();

[sky, 2016/10/13 16:21:21]

Will this trigger activation at the native level? Say when this test is run on
linux or windows non-chromeos? If so, it should move to interactive tests.

[Qiang(Joe) Xu, 2016/10/14 01:42:39]

Because I put it in NativeWidgetAuraTest. So it should only run in ChromeOS.
Yeah, I should put it in widget_interactive_uitest to support more platforms.

However, it is a little tricky here. widget_interactive_uitest uses
ViewsTestBase, which eventually set up this:
https://cs.chromium.org/chromium/src/ui/views/test/views_test_helper_aura.cc?...

The DefaultActivationClient activates window whenever requested. However, we
need something that widget is non-activatable first and then activatable. On
chromeos, widget will always be activatable in widget_interactive_uitest.

(1) We properly want an overridden focus rules.
(2) split the test into NativeWidgetAuraTest and DesktopNativeWidgetAuraTest
(which can be put in widget_interactive_uitest).
What do you think?

[sky, 2016/10/14 15:41:36]

NativeWidgetAuraTest runs everywhere but mac (mac doesn't support aura, so it
isn't applicable).
I'm fine keeping the test specific to NativeWidgetAura, but you need to make
sure it doesn't try to do activation at the native level. If it does, then it
needs to be moved to interactive ui tests.

[Qiang(Joe) Xu, 2016/10/19 05:13:52]

Since it does cause OnNativeWidgetActivationChanged, I then move the test to
interactive_ui_test. 
Since the DefaultActivationClient activates window whenever requested, the test
sets its own ActivationClient (reference: NativeWidgetAuraTest).
I don't know why the test is failing on OS_WIN. Right now, I just disable it.
Scott, do you have an idea on why test is failing on OS_WIN?

+  EXPECT_TRUE(textfield2->HasFocus());
+  EXPECT_FALSE(textfield0->HasFocus());
+  EXPECT_FALSE(textfield1->HasFocus());
+  textfield0->RequestFocus();
+  EXPECT_TRUE(textfield2->HasFocus());
+  EXPECT_FALSE(textfield0->HasFocus());
+  EXPECT_FALSE(textfield1->HasFocus());
+
+  // |widget1| sets to activatable. If now there is an Activate() call, focus
+  // should restore to |textfield0| properly.
+  widget1->widget_delegate()->set_can_activate(true);
+  widget1->Activate();
+  EXPECT_TRUE(textfield0->HasFocus());
+  EXPECT_FALSE(textfield1->HasFocus());
+  EXPECT_FALSE(textfield2->HasFocus());
+}
+
 // A WindowObserver that counts kShowStateKey property changes.
 class TestWindowObserver : public aura::WindowObserver {
  public:
   explicit TestWindowObserver(gfx::NativeWindow window) : window_(window) {
     window_->AddObserver(this);
   }
   ~TestWindowObserver() override {
     window_->RemoveObserver(this);
   }
 
@@ skipping 433 matching lines @@
   EXPECT_FALSE(delegate.view()->HasFocus());
 
   test_focus_rules()->set_can_activate(true);
   views::test::TestInitialFocusWidgetDelegate delegate2(root_window());
   delegate2.GetWidget()->Show();
   EXPECT_TRUE(delegate2.view()->HasFocus());
 }
 
 }  // namespace
 }  // namespace views