Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2371103002: Revert of [tracing] Support ConvertableToTraceFormat argument type. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, lpy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tracing] Support ConvertableToTraceFormat argument type. (patchset #5 id:80001 of https://codereview.chromium.org/2367603002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10100 See also: https://github.com/v8/v8/wiki/Blink%20layout%20tests Original issue's description: > [tracing] Support ConvertableToTraceFormat argument type. > > Drive-by: Use perfect forwarding for AddTraceEvent arguments. > > BUG=406277 > > Committed: https://crrev.com/dcac49af485fe5d4c0027f153901435dbb29c232 > Cr-Commit-Position: refs/heads/master@{#39742} TBR=jochen@chromium.org,caseq@chromium.org,fmeawad@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406277 Committed: https://crrev.com/2c9661a62aa5e4b8f2055a90e6ce2ca43cdb3695 Cr-Commit-Position: refs/heads/master@{#39750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -208 lines) Patch
M include/libplatform/v8-tracing.h View 5 chunks +18 lines, -30 lines 0 comments Download
M include/v8-platform.h View 4 chunks +9 lines, -45 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/libplatform/tracing/trace-object.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M src/libplatform/tracing/trace-writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/libplatform/tracing/trace-writer.cc View 3 chunks +1 line, -14 lines 0 comments Download
M src/libplatform/tracing/tracing-controller.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/tracing/trace-event.h View 5 chunks +13 lines, -50 lines 0 comments Download
M test/cctest/libplatform/test-tracing.cc View 7 chunks +7 lines, -32 lines 0 comments Download
M test/cctest/test-trace-event.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [tracing] Support ConvertableToTraceFormat argument type.
4 years, 2 months ago (2016-09-27 07:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2371103002/1
4 years, 2 months ago (2016-09-27 07:01:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 07:01:49 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:02:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c9661a62aa5e4b8f2055a90e6ce2ca43cdb3695
Cr-Commit-Position: refs/heads/master@{#39750}

Powered by Google App Engine
This is Rietveld 408576698