Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2371053003: [Cronet] Delete bidi stream asynchronously in OnFailed and MaybeOnSucceeded callbacks on iOS. (Closed)
Patch Set: Address Andrei's comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/ios/test/cronet_bidirectional_stream_test.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index b2b53637de2228347bca00ced7d5e230f0f789d9..c2dfc83fece5881f86ef944bee907ba682b1e33e 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -69,6 +69,8 @@ def main():
help='build for physical iphone')
parser.add_argument('-r', '--release', action='store_true',
help='use release configuration')
+ parser.add_argument('-a', '--asan', action='store_true',
+ help='use address sanitizer')
options, extra_options_list = parser.parse_known_args()
print options
@@ -86,6 +88,9 @@ def main():
else:
gn_args += ' target_cpu="x64" '
out_dir_suffix = '-iphonesimulator'
+ if options.asan:
+ gn_args += ' is_asan=true use_xcode_clang=true '
+ out_dir_suffix += '-asan'
else:
target_os = 'android'
test_target = 'cronet_test_instrumentation_apk'
« no previous file with comments | « components/cronet/ios/test/cronet_bidirectional_stream_test.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698