Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: android_webview/BUILD.gn

Issue 2371053002: GN(android): Use foreach() loops when dealing with locales (Closed)
Patch Set: rename to android_chrome_omitted_locales Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/locales.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 3ef9827564cf4e2c263efb89885ac196e3fe5695..e092d23a7e7ae33d958e5fc5dc30cc2b8cd62583 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -54,61 +54,10 @@ webview_repack_locales("repack_locales") {
}
locale_pak_resources("locale_paks") {
- sources = [
- "$root_out_dir/android_webview/locales/am.pak",
- "$root_out_dir/android_webview/locales/ar.pak",
- "$root_out_dir/android_webview/locales/bg.pak",
- "$root_out_dir/android_webview/locales/bn.pak",
- "$root_out_dir/android_webview/locales/ca.pak",
- "$root_out_dir/android_webview/locales/cs.pak",
- "$root_out_dir/android_webview/locales/da.pak",
- "$root_out_dir/android_webview/locales/de.pak",
- "$root_out_dir/android_webview/locales/el.pak",
- "$root_out_dir/android_webview/locales/en-GB.pak",
- "$root_out_dir/android_webview/locales/en-US.pak",
- "$root_out_dir/android_webview/locales/es-419.pak",
- "$root_out_dir/android_webview/locales/es.pak",
- "$root_out_dir/android_webview/locales/et.pak",
- "$root_out_dir/android_webview/locales/fa.pak",
- "$root_out_dir/android_webview/locales/fi.pak",
- "$root_out_dir/android_webview/locales/fil.pak",
- "$root_out_dir/android_webview/locales/fr.pak",
- "$root_out_dir/android_webview/locales/gu.pak",
- "$root_out_dir/android_webview/locales/he.pak",
- "$root_out_dir/android_webview/locales/hi.pak",
- "$root_out_dir/android_webview/locales/hr.pak",
- "$root_out_dir/android_webview/locales/hu.pak",
- "$root_out_dir/android_webview/locales/id.pak",
- "$root_out_dir/android_webview/locales/it.pak",
- "$root_out_dir/android_webview/locales/ja.pak",
- "$root_out_dir/android_webview/locales/kn.pak",
- "$root_out_dir/android_webview/locales/ko.pak",
- "$root_out_dir/android_webview/locales/lt.pak",
- "$root_out_dir/android_webview/locales/lv.pak",
- "$root_out_dir/android_webview/locales/ml.pak",
- "$root_out_dir/android_webview/locales/mr.pak",
- "$root_out_dir/android_webview/locales/ms.pak",
- "$root_out_dir/android_webview/locales/nb.pak",
- "$root_out_dir/android_webview/locales/nl.pak",
- "$root_out_dir/android_webview/locales/pl.pak",
- "$root_out_dir/android_webview/locales/pt-BR.pak",
- "$root_out_dir/android_webview/locales/pt-PT.pak",
- "$root_out_dir/android_webview/locales/ro.pak",
- "$root_out_dir/android_webview/locales/ru.pak",
- "$root_out_dir/android_webview/locales/sk.pak",
- "$root_out_dir/android_webview/locales/sl.pak",
- "$root_out_dir/android_webview/locales/sr.pak",
- "$root_out_dir/android_webview/locales/sv.pak",
- "$root_out_dir/android_webview/locales/sw.pak",
- "$root_out_dir/android_webview/locales/ta.pak",
- "$root_out_dir/android_webview/locales/te.pak",
- "$root_out_dir/android_webview/locales/th.pak",
- "$root_out_dir/android_webview/locales/tr.pak",
- "$root_out_dir/android_webview/locales/uk.pak",
- "$root_out_dir/android_webview/locales/vi.pak",
- "$root_out_dir/android_webview/locales/zh-CN.pak",
- "$root_out_dir/android_webview/locales/zh-TW.pak",
- ]
+ sources = []
+ foreach(_locale, locales) {
+ sources += [ "$root_out_dir/android_webview/locales/$_locale.pak" ]
+ }
deps = [
":repack_locales",
]
@@ -232,60 +181,10 @@ grit("generate_aw_strings") {
source = "ui/aw_strings.grd"
outputs = [
"grit/aw_strings.h",
- "aw_strings_am.pak",
- "aw_strings_ar.pak",
- "aw_strings_bg.pak",
- "aw_strings_bn.pak",
- "aw_strings_ca.pak",
- "aw_strings_cs.pak",
- "aw_strings_da.pak",
- "aw_strings_de.pak",
- "aw_strings_el.pak",
- "aw_strings_en-US.pak",
- "aw_strings_en-GB.pak",
- "aw_strings_es.pak",
- "aw_strings_es-419.pak",
- "aw_strings_et.pak",
- "aw_strings_fa.pak",
- "aw_strings_fi.pak",
- "aw_strings_fil.pak",
- "aw_strings_fr.pak",
- "aw_strings_gu.pak",
- "aw_strings_he.pak",
- "aw_strings_hi.pak",
- "aw_strings_hr.pak",
- "aw_strings_hu.pak",
- "aw_strings_id.pak",
- "aw_strings_it.pak",
- "aw_strings_ja.pak",
- "aw_strings_kn.pak",
- "aw_strings_ko.pak",
- "aw_strings_lt.pak",
- "aw_strings_lv.pak",
- "aw_strings_ml.pak",
- "aw_strings_mr.pak",
- "aw_strings_ms.pak",
- "aw_strings_nl.pak",
- "aw_strings_nb.pak",
- "aw_strings_pl.pak",
- "aw_strings_pt-BR.pak",
- "aw_strings_pt-PT.pak",
- "aw_strings_ro.pak",
- "aw_strings_ru.pak",
- "aw_strings_sk.pak",
- "aw_strings_sl.pak",
- "aw_strings_sr.pak",
- "aw_strings_sv.pak",
- "aw_strings_sw.pak",
- "aw_strings_ta.pak",
- "aw_strings_te.pak",
- "aw_strings_th.pak",
- "aw_strings_tr.pak",
- "aw_strings_uk.pak",
- "aw_strings_vi.pak",
- "aw_strings_zh-CN.pak",
- "aw_strings_zh-TW.pak",
]
+ foreach(_locale, locales) {
+ outputs += [ "aw_strings_${_locale}.pak" ]
+ }
}
grit("generate_components_strings") {
@@ -305,60 +204,6 @@ grit("generate_components_strings") {
]
outputs = [
"grit/components_strings.h",
- "components_strings_am.pak",
- "components_strings_ar.pak",
- "components_strings_bg.pak",
- "components_strings_bn.pak",
- "components_strings_ca.pak",
- "components_strings_cs.pak",
- "components_strings_da.pak",
- "components_strings_de.pak",
- "components_strings_el.pak",
- "components_strings_en-GB.pak",
- "components_strings_en-US.pak",
- "components_strings_es.pak",
- "components_strings_es-419.pak",
- "components_strings_et.pak",
- "components_strings_fa.pak",
- "components_strings_fake-bidi.pak",
- "components_strings_fi.pak",
- "components_strings_fil.pak",
- "components_strings_fr.pak",
- "components_strings_gu.pak",
- "components_strings_he.pak",
- "components_strings_hi.pak",
- "components_strings_hr.pak",
- "components_strings_hu.pak",
- "components_strings_id.pak",
- "components_strings_it.pak",
- "components_strings_ja.pak",
- "components_strings_kn.pak",
- "components_strings_ko.pak",
- "components_strings_lt.pak",
- "components_strings_lv.pak",
- "components_strings_ml.pak",
- "components_strings_mr.pak",
- "components_strings_ms.pak",
- "components_strings_nl.pak",
- "components_strings_nb.pak",
- "components_strings_pl.pak",
- "components_strings_pt-BR.pak",
- "components_strings_pt-PT.pak",
- "components_strings_ro.pak",
- "components_strings_ru.pak",
- "components_strings_sk.pak",
- "components_strings_sl.pak",
- "components_strings_sr.pak",
- "components_strings_sv.pak",
- "components_strings_sw.pak",
- "components_strings_ta.pak",
- "components_strings_te.pak",
- "components_strings_th.pak",
- "components_strings_tr.pak",
- "components_strings_uk.pak",
- "components_strings_vi.pak",
- "components_strings_zh-CN.pak",
- "components_strings_zh-TW.pak",
"java/res/values-am/components_strings.xml",
"java/res/values-ar/components_strings.xml",
"java/res/values-bg/components_strings.xml",
@@ -404,6 +249,9 @@ grit("generate_components_strings") {
"java/res/values-zh-rTW/components_strings.xml",
"java/res/values/components_strings.xml",
]
+ foreach(_locale, locales) {
+ outputs += [ "components_strings_${_locale}.pak" ]
+ }
}
source_set("webview_entry_point") {
« no previous file with comments | « no previous file | build/config/locales.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698