Small: Start checking URLs using PVer4. Verdict not returned to client yet.

components/safe_browsing_db/v4_local_database_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_LOCAL_DATABASE_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_LOCAL_DATABASE_MANAGER_H_
 
 // A class that provides the interface between the SafeBrowsing protocol manager
 // and database that holds the downloaded updates.
 
@@ skipping 10 matching lines @@
 using content::ResourceType;
 
 namespace safe_browsing {
 
 typedef unsigned ThreatSeverity;
 
 // Manages the local, on-disk database of updates downloaded from the
 // SafeBrowsing service and interfaces with the protocol manager.
 class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {
  public:
   enum class ClientCallbackType {

[Nathan Parker, 2016/09/28 22:25:55]

(unrelated nit: Does ClientCallbackType need to be public?)

[vakh (use Gerrit instead), 2016/09/28 23:00:01]

No. Made protected.

     // This represents the case when we're trying to determine if a URL is
     // unsafe from the following perspectives: Malware, Phishing, UwS.
     CHECK_BROWSE_URL = 0,
 
     // This should always be the last value.
     CHECK_MAX
   };
 
-  // Construct V4LocalDatabaseManager.
-  // Must be initialized by calling StartOnIOThread() before using.
-  V4LocalDatabaseManager(const base::FilePath& base_path);
+  // Create and return an instance of V4LocalDatabaseManager, if Finch trial
+  // allows it; nullptr otherwise.
+  static V4LocalDatabaseManager* Create(const base::FilePath& base_path);

[Nathan Parker, 2016/09/28 22:25:55]

return a unique_ptr

[vakh (use Gerrit instead), 2016/09/28 23:00:02]

It looks like the destructor of the class needs to be public for creating a
unique_ptr but the destructor of V4LocalDatabaseManager can't be made public
according to Chromium style guide.

../../components/safe_browsing_db/v4_local_database_manager.cc:87:1: error:
[chromium-style] Classes that are ref-counted should have destructors that are
declared protected or private.
V4LocalDatabaseManager::~V4LocalDatabaseManager() {
^
../../components/safe_browsing_db/v4_local_database_manager.h:29:32: note:
[chromium-style] 'V4LocalDatabaseManager' inherits from
'safe_browsing::SafeBrowsingDatabaseManager' here
class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {
                               ^
../../components/safe_browsing_db/database_manager.h:36:7: note:
[chromium-style] 'SafeBrowsingDatabaseManager' inherits from
'base::RefCountedThreadSafe<SafeBrowsingDatabaseManager>' here
    : public base::RefCountedThreadSafe<SafeBrowsingDatabaseManager> {

[Nathan Parker, 2016/09/28 23:50:14]

Ah yes, it's a base::RefCountedThreadSafe<> decendent, so maybe it should return
a scoped_refptr<v4ldm> (via make_scoped_refptr(..)).  Or maybe it'd need to be a
scoped_refptr<sbdm>, which might be annoying for tests since you'd need to
upcast it.  

If none of that works, this is probably ok.

 
   //
   // SafeBrowsingDatabaseManager implementation
   //
 
   void CancelCheck(Client* client) override;
   bool CanCheckResourceType(content::ResourceType resource_type) const override;
   bool CanCheckUrl(const GURL& url) const override;
   bool ChecksAreAlwaysAsync() const override;
   bool CheckBrowseUrl(const GURL& url, Client* client) override;
@@ skipping 14 matching lines @@
   bool IsSupported() const override;
   void StartOnIOThread(net::URLRequestContextGetter* request_context_getter,
                        const V4ProtocolConfig& config) override;
   void StopOnIOThread(bool shutdown) override;
 
   //
   // End: SafeBrowsingDatabaseManager implementation
   //
 
  protected:
+  // Construct V4LocalDatabaseManager.
+  // Must be initialized by calling StartOnIOThread() before using.
+  V4LocalDatabaseManager(const base::FilePath& base_path);
+
   // The information we need to process a URL safety reputation request and
   // respond to the SafeBrowsing client that asked for it.
   // TODO(vakh): In its current form, it only includes information for
   // |CheckBrowseUrl| method. Extend it to serve other methods on |client|.
   struct PendingCheck {
     PendingCheck(Client* client,
                  ClientCallbackType client_callback_type,
                  const StoresToCheck& stores_to_check,
                  const GURL& url);
 
@@ skipping 135 matching lines @@
   // The protocol manager that downloads the hash prefix updates.
   std::unique_ptr<V4UpdateProtocolManager> v4_update_protocol_manager_;
 
   friend class base::RefCountedThreadSafe<V4LocalDatabaseManager>;
   DISALLOW_COPY_AND_ASSIGN(V4LocalDatabaseManager);
 };  // class V4LocalDatabaseManager
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_LOCAL_DATABASE_MANAGER_H_