Small: Start checking URLs using PVer4. Verdict not returned to client yet.

chrome/browser/safe_browsing/services_delegate_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/services_delegate_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
@@ skipping 46 matching lines @@
     net::URLRequestContextGetter* context_getter) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 #if defined(SAFE_BROWSING_CSD)
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableClientSidePhishingDetection)) {
     csd_service_.reset(ClientSideDetectionService::Create(context_getter));
   }
 #endif  // defined(SAFE_BROWSING_CSD)
 }
 
+const scoped_refptr<V4LocalDatabaseManager>&
+ServicesDelegateImpl::v4_local_database_manager() const {
+  return v4_local_database_manager_;
+}
+
 void ServicesDelegateImpl::Initialize() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   download_service_.reset(
       (services_creator_ &&
        services_creator_->CanCreateDownloadProtectionService())
           ? services_creator_->CreateDownloadProtectionService()
           : CreateDownloadProtectionService());
   incident_service_.reset(
       (services_creator_ &&
        services_creator_->CanCreateIncidentReportingService())
@@ skipping 105 matching lines @@
 }
 
 V4LocalDatabaseManager* ServicesDelegateImpl::CreateV4LocalDatabaseManager() {
   return new V4LocalDatabaseManager(SafeBrowsingService::GetBaseFilename());
 }
 
 bool ServicesDelegateImpl::IsV4LocalDatabaseManagerEnabled() {
 #ifndef NDEBUG
   return true;
 #else
   return base::FeatureList::IsEnabled(

[Nathan Parker, 2016/09/28 17:24:14]

Double checking the expected outcome here: All debug builds and 25% of
dev/canary will, in addition to loading the v4 DBs, start doing parallel checks
for all browse URLs.

I think this effectively merges the planned V4Parallel and V4JustUpdate
experiment groups into one, currently called V4JustUpdate.  If you want to go
that way, can you update the doc, and decide what to do with the experiment
group name? 
https://docs.google.com/document/d/1fA3tvcTRtYOV5dNMst45OE6RXTr_cCtNsZijhB6bG...

Alternately, to keep them separate, you'll want to check for the
"SafeBrowingV4ParallelCheck" feature and do parallel checking only if that's
set.

[vakh (use Gerrit instead), 2016/09/28 22:13:35]

Good catch. Changed.

       kSafeBrowsingV4LocalDatabaseManagerEnabled);
 #endif
 }
 
 }  // namespace safe_browsing