Issue 23710072: fix fontconfig backend to only cache new fonts if their outName was unique

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23710072: fix fontconfig backend to only cache new fonts if their outName was unique (Closed)

Created:
7 years, 3 months ago by reed1

Modified:
7 years, 3 months ago

Reviewers:
bungeman-skia, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix fontconfig backend to only cache new fonts if their outName was unique BUG= R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=11364

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_fontconfig.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	tests/FontMgrTest.cpp	View		2 chunks	+22 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

next CL -- greatly expand list of alias-names to test against on all platforms... [ ...

7 years, 3 months ago (2013-09-18 20:30:26 UTC) #2

bungeman-skia

lgtm with test change and passing https://codereview.chromium.org/23710072/diff/1/tests/FontMgrTest.cpp File tests/FontMgrTest.cpp (right): https://codereview.chromium.org/23710072/diff/1/tests/FontMgrTest.cpp#newcode20 tests/FontMgrTest.cpp:20: const char* inName ...

7 years, 3 months ago (2013-09-18 20:31:02 UTC) #3

reed1

7 years, 3 months ago (2013-09-18 20:32:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11364 (presubmit successful).

Expand Messages | Collapse Messages