Issue 23710063: Don't run tests with the profiler when USE_SIMULATOR is defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23710063: Don't run tests with the profiler when USE_SIMULATOR is defined. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 2 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't run tests with the profiler when USE_SIMULATOR is defined. BUG=v8:2874 R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16757

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

On 2013/09/17 10:30:00, Benedikt Meurer wrote: > PTAL lgtm

7 years, 3 months ago (2013-09-17 10:39:24 UTC) #2

yurys

7 years, 2 months ago (2013-09-25 06:40:54 UTC) #4

Message was sent while issue was closed.

On 2013/09/17 10:57:26, Benedikt Meurer wrote:
> Committed patchset #1 manually as r16757.

Does it make sense to revert https://code.google.com/p/v8/source/detail?r=16665
now that the macro is changed?

Expand Messages | Collapse Messages