Issue 23710053: [External patch] Source-over support for SkLumaXfermode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23710053: [External patch] Source-over support for SkLumaXfermode. (Closed)

Created:
7 years, 3 months ago by f(malita)

Modified:
7 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, parvu_adobe.com, rmistry, bsalomon

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[External patch] Source-over support for SkLumaXfermode. This is a patch by Andrei Parvu <parvu@adobe.com>; (Adobe CLA signer). Original CL/review: https://codereview.chromium.org/24078006/ GM:lumamode will need rebaselining after landing this. --- In order to use CSS luminance masking, we need to be able to create an instance of SkLumaXfermode which can receive a kSrcOver mode, and applies that mode after converting the source using the luminance-to-alpha coefficients. BUG=289420 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11312

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -15 lines)			Patch
M	bench/XfermodeBench.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gm/lumamode.cpp	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	include/effects/SkLumaXfermode.h	View	4 chunks	+6 lines, -3 lines	0 comments	Download
M	src/effects/SkLumaXfermode.cpp	View	7 chunks	+63 lines, -8 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_chromium.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/23710053/1

7 years, 3 months ago (2013-09-16 15:36:49 UTC) #3

f(malita)

7 years, 3 months ago (2013-09-17 13:09:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11312 (presubmit successful).

Expand Messages | Collapse Messages