Issue 23710047: Merge 157615 "Keep AudioScheduledSourceNode alive until onended ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23710047: Merge 157615 "Keep AudioScheduledSourceNode alive until onended ..." (Closed)

Created:
7 years, 3 months ago by Raymond Toy (Google)

Modified:
7 years, 3 months ago

Reviewers:
Raymond Toy (Google)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1599/

Visibility:
Public.

Merge 157615 "Keep AudioScheduledSourceNode alive until onended ..." > Keep AudioScheduledSourceNode alive until onended is called. > > Also, if the document has already gone away, we want to avoid firing > the event at all. This is similar to what ScriptProcessorNode does > with events. > > BUG=269753 > > Review URL: https://chromiumcodereview.appspot.com/23596014 TBR=rtoy@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157762

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
	M	Source/modules/webaudio/AudioScheduledSourceNode.h	View		2 chunks	+11 lines, -1 line	0 comments	Download
	M	Source/modules/webaudio/AudioScheduledSourceNode.cpp	View		1 chunk	+16 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r157762.