Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 23710025: thread isolate for logging calls (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

thread isolate for logging calls R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16646

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/platform-cygwin.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-freebsd.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-linux.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-macos.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-openbsd.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-solaris.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/string-stream.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-11 09:36:44 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-11 10:41:34 UTC) #2
dcarney
7 years, 3 months ago (2013-09-11 10:59:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698