Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: Source/core/loader/FrameLoader.h

Issue 23710021: Merge 157196 "Don't wait to notify client of spoof attempt if a ..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1599/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.h
===================================================================
--- Source/core/loader/FrameLoader.h (revision 157485)
+++ Source/core/loader/FrameLoader.h (working copy)
@@ -115,9 +115,16 @@
// FIXME: clear() is trying to do too many things. We should break it down into smaller functions (ideally with fewer raw Boolean parameters).
void clear(bool clearWindowProperties = true, bool clearScriptObjects = true, bool clearFrameView = true);
+ // Sets a timer to notify the client that the initial empty document has
+ // been accessed, and thus it is no longer safe to show a provisional URL
+ // above the document without risking a URL spoof.
void didAccessInitialDocument();
- void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);
+ // If the initial empty document is showing and has been accessed, this
+ // cancels the timer and immediately notifies the client in cases that
+ // waiting to notify would allow a URL spoof.
+ void notifyIfInitialDocumentAccessed();
+
bool isLoading() const;
int numPendingOrLoadingRequests(bool recurse) const;
@@ -245,6 +252,7 @@
bool allChildrenAreComplete() const; // immediate children, not all descendants
void checkTimerFired(Timer<FrameLoader>*);
+ void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);
void loadSameDocumentItem(HistoryItem*);
void loadDifferentDocumentItem(HistoryItem*);
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698