Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/valgrind/tsan/suppressions.txt

Issue 23710015: Tentatively delete the sqlite3_initialize suppression. The race should've been fixed in r212984 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # There are a few kinds of suppressions in this file. 1 # There are a few kinds of suppressions in this file.
2 # 1. third party stuff we have no control over 2 # 1. third party stuff we have no control over
3 # 3 #
4 # 2. intentional unit test errors, or stuff that is somehow a false positive 4 # 2. intentional unit test errors, or stuff that is somehow a false positive
5 # in our own code, or stuff that is so trivial it's not worth fixing 5 # in our own code, or stuff that is so trivial it's not worth fixing
6 # 6 #
7 # 3. Suppressions for real chromium bugs that are not yet fixed. 7 # 3. Suppressions for real chromium bugs that are not yet fixed.
8 # These should all be in chromium's bug tracking system (but a few aren't yet). 8 # These should all be in chromium's bug tracking system (but a few aren't yet).
9 # Periodically we should sweep this file and the bug tracker clean by 9 # Periodically we should sweep this file and the bug tracker clean by
10 # running overnight and removing outdated bugs/suppressions. 10 # running overnight and removing outdated bugs/suppressions.
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 } 159 }
160 160
161 { 161 {
162 Two writes, same value (under sqlite3Malloc) 162 Two writes, same value (under sqlite3Malloc)
163 ThreadSanitizer:Race 163 ThreadSanitizer:Race
164 ... 164 ...
165 fun:sqlite3Malloc* 165 fun:sqlite3Malloc*
166 } 166 }
167 167
168 { 168 {
169 Two writes, same value (sqlite3_initialize)
170 ThreadSanitizer:Race
171 fun:sqlite3_initialize
172 fun:openDatabase
173 }
174
175 {
176 bug_84094_a (Could be benign. See bug for details) 169 bug_84094_a (Could be benign. See bug for details)
177 ThreadSanitizer:Race 170 ThreadSanitizer:Race
178 ... 171 ...
179 fun:pcache1Fetch 172 fun:pcache1Fetch
180 fun:sqlite3PcacheFetch 173 fun:sqlite3PcacheFetch
181 } 174 }
182 175
183 { 176 {
184 bug_84094_b (Could be benign. See bug for details) 177 bug_84094_b (Could be benign. See bug for details)
185 ThreadSanitizer:Race 178 ThreadSanitizer:Race
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 } 1122 }
1130 { 1123 {
1131 bug_268924 1124 bug_268924
1132 ThreadSanitizer:Race 1125 ThreadSanitizer:Race
1133 fun:base::PowerMonitor::PowerMonitor 1126 fun:base::PowerMonitor::PowerMonitor
1134 fun:content::ChildThread::Init 1127 fun:content::ChildThread::Init
1135 fun:content::ChildThread::ChildThread 1128 fun:content::ChildThread::ChildThread
1136 fun:content::UtilityThreadImpl::UtilityThreadImpl 1129 fun:content::UtilityThreadImpl::UtilityThreadImpl
1137 fun:content::UtilityMainThread::InitInternal 1130 fun:content::UtilityMainThread::InitInternal
1138 } 1131 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698