Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/mac/gyptest-app.py

Issue 23710010: ninja&make/mac: Convert .strings files to UTF-16LE, not just UTF-16. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/mac_tool.py ('K') | « pylib/gyp/mac_tool.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-app.py
===================================================================
--- test/mac/gyptest-app.py (revision 1703)
+++ test/mac/gyptest-app.py (working copy)
@@ -42,9 +42,12 @@
test.must_not_contain(info_plist, '${MACOSX_DEPLOYMENT_TARGET}');
# Resources
- test.built_file_must_exist(
+ strings = test.built_file_path(
'Test App Gyp.app/Contents/Resources/English.lproj/InfoPlist.strings',
chdir='app-bundle')
+ test.must_exist(strings)
+ test.must_contain(strings, '\xff\xfe' + '/* Localized'.encode('utf-16le'))
Robert Sesek 2013/08/29 17:48:23 Comment that this is the BOM?
Nico 2013/08/29 17:55:10 Done.
+
test.built_file_must_exist(
'Test App Gyp.app/Contents/Resources/English.lproj/MainMenu.nib',
chdir='app-bundle')
« pylib/gyp/mac_tool.py ('K') | « pylib/gyp/mac_tool.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698