Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/ui/views/controls/combobox/combobox.cc

Issue 23710009: Revert 219673 "Fix Views Combobox and Tree View text input." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/chromeos/input_method/textinput_test_helper.cc ('k') | trunk/src/ui/views/controls/combobox/native_combobox_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/views/controls/combobox/combobox.cc
===================================================================
--- trunk/src/ui/views/controls/combobox/combobox.cc (revision 220120)
+++ trunk/src/ui/views/controls/combobox/combobox.cc (working copy)
@@ -140,14 +140,17 @@
}
void Combobox::OnFocus() {
- View::OnFocus();
// Forward the focus to the wrapper.
- if (native_wrapper_)
+ if (native_wrapper_) {
native_wrapper_->SetFocus();
+ NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_FOCUS, true);
+ } else {
+ View::OnFocus(); // Will focus the RootView window (so we still get
+ // keyboard messages).
+ }
}
void Combobox::OnBlur() {
- View::OnBlur();
if (selector_)
selector_->OnViewBlur();
if (native_wrapper_)
« no previous file with comments | « trunk/src/chrome/browser/chromeos/input_method/textinput_test_helper.cc ('k') | trunk/src/ui/views/controls/combobox/native_combobox_views_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698