Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 23710002: Revert "Cross-compiling from Linux to Android requires -lrt for the host toolset.", "Fix Visual Stu… (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Cross-compiling from Linux to Android requires -lrt for the host toolset.", "Fix Visual Studio debug build after r16398." and "Reland "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class."" This reverts commit r16398, r16399 and r16402 for breaking the Windows WebKit tests. Will reland fix which doesn't use High Resolution Timer for ElapsedTimer (we suspect QueryPerformanceCounter overhead is responsible for test breakage). TBR=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -1267 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 4 chunks +13 lines, -12 lines 0 comments Download
M src/compiler.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M src/counters.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/counters.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/cpu-profiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +15 lines, -11 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/log.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/parser.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/platform-win32.cc View 12 chunks +106 lines, -21 lines 0 comments Download
D src/platform/elapsed-timer.h View 1 chunk +0 lines, -120 lines 0 comments Download
D src/platform/time.h View 1 chunk +0 lines, -381 lines 0 comments Download
D src/platform/time.cc View 1 chunk +0 lines, -482 lines 0 comments Download
M src/profile-generator.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/win32-headers.h View 4 chunks +2 lines, -5 lines 0 comments Download
M src/win32-math.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 5 chunks +11 lines, -9 lines 0 comments Download
D test/cctest/test-time.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r16405.
7 years, 3 months ago (2013-08-28 14:32:42 UTC) #1
Michael Achenbach
On 2013/08/28 14:32:42, Benedikt Meurer wrote: > Committed patchset #1 manually as r16405. lgtm
7 years, 3 months ago (2013-08-28 14:36:44 UTC) #2
yurys
I'm curious what the plan regarding high resolution ElapsedTimer is. Are you going to support ...
7 years, 3 months ago (2013-08-28 15:12:48 UTC) #3
Benedikt Meurer
On 2013/08/28 15:12:48, Yury Semikhatsky wrote: > I'm curious what the plan regarding high resolution ...
7 years, 3 months ago (2013-08-28 17:14:55 UTC) #4
yurys
7 years, 3 months ago (2013-08-29 07:56:18 UTC) #5
Message was sent while issue was closed.
On 2013/08/28 17:14:55, Benedikt Meurer wrote:
> On 2013/08/28 15:12:48, Yury Semikhatsky wrote:
> > I'm curious what the plan regarding high resolution ElapsedTimer is. Are you
> > going to support special mode for it? We obviously need highres one for cpu
> > profiler.
> 
> Of course. It looks like the problems we faced on Windows were caused by a
> missing millisecond to microsecond conversion in the fallback tick clock. I
have
> a fix for that already, and will test tomorrow.
> If this turns out to work, then there's now reason for ElapsedTimer not to use
> HighResNow, and we'll keep it that way.
> If HighResNow is still an issue afterwards, we'll add some HighResElapsedTimer
> or something like that.

Great, thanks for clarifying!

Powered by Google App Engine
This is Rietveld 408576698