Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2370953002: Revert of Fix bufferIndex check in VulkanWindowContext (Closed)

Created:
4 years, 2 months ago by egdaniel
Modified:
4 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix bufferIndex check in VulkanWindowContext (patchset #1 id:1 of https://codereview.chromium.org/2363353003/ ) Reason for revert: Fix not correct. Original issue's description: > Fix bufferIndex check in VulkanWindowContext > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 > > Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/804af7d8de27edbc45315d4cce17baffed59a270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Fix bufferIndex check in VulkanWindowContext
4 years, 2 months ago (2016-09-26 19:30:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370953002/1
4 years, 2 months ago (2016-09-26 19:30:41 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 19:30:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/804af7d8de27edbc45315d4cce17baffed59a270

Powered by Google App Engine
This is Rietveld 408576698