Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2370943004: Add fuzzer for jbig2 parsing (Closed)

Created:
4 years, 2 months ago by kcwu
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : address thestig's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M testing/libfuzzer/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kcwu
p.s. I choice you as reviewer because you are the only common owner of pdf/ ...
4 years, 2 months ago (2016-09-27 16:33:35 UTC) #2
Lei Zhang
https://codereview.chromium.org/2370943004/diff/1/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc File testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc (right): https://codereview.chromium.org/2370943004/diff/1/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc#newcode21 testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc:21: return 0; nit: blank line after, just like line ...
4 years, 2 months ago (2016-09-27 16:39:54 UTC) #3
kcwu
https://codereview.chromium.org/2370943004/diff/1/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc File testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc (right): https://codereview.chromium.org/2370943004/diff/1/testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc#newcode21 testing/libfuzzer/pdf_codec_jbig2_fuzzer.cc:21: return 0; On 2016/09/27 16:39:54, Lei Zhang wrote: > ...
4 years, 2 months ago (2016-09-27 17:03:08 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-09-27 17:05:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370943004/20001
4 years, 2 months ago (2016-09-27 17:06:33 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:06:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ec7a9455c15b2cebb75a6036c8636beb601e...

Powered by Google App Engine
This is Rietveld 408576698