Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2370943003: Use LibraryLoader to check for native library (Closed)

Created:
4 years, 2 months ago by hayesjordan
Modified:
4 years, 2 months ago
Reviewers:
Ted C, cco3, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LibraryLoader to check for native library BUG=636490 Committed: https://crrev.com/af547481c048ad892f64ee375a6698ff742605cd Cr-Commit-Position: refs/heads/master@{#422686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 8 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
cco3
LGTM
4 years, 2 months ago (2016-09-27 16:56:10 UTC) #4
gone
Sending to Ted since he was the last to respond on that clank-team thread.
4 years, 2 months ago (2016-09-27 17:13:54 UTC) #6
Ted C
lgtm While I don't think this is the best way we should be doing this, ...
4 years, 2 months ago (2016-09-30 23:16:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370943003/1
4 years, 2 months ago (2016-10-04 02:02:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 03:10:02 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 03:12:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af547481c048ad892f64ee375a6698ff742605cd
Cr-Commit-Position: refs/heads/master@{#422686}

Powered by Google App Engine
This is Rietveld 408576698