Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.cc

Issue 237093003: Revert "Handlify DebugLookupResultValue." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 793 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 804
805 if (!result->IsProperty()) { 805 if (!result->IsProperty()) {
806 *attributes = ABSENT; 806 *attributes = ABSENT;
807 return factory->undefined_value(); 807 return factory->undefined_value();
808 } 808 }
809 *attributes = result->GetAttributes(); 809 *attributes = result->GetAttributes();
810 810
811 Handle<Object> value; 811 Handle<Object> value;
812 switch (result->type()) { 812 switch (result->type()) {
813 case NORMAL: { 813 case NORMAL: {
814 value = JSObject::GetNormalizedProperty( 814 DisallowHeapAllocation no_gc;
815 handle(result->holder(), isolate), result); 815 value = handle(result->holder()->GetNormalizedProperty(result), isolate);
816 break; 816 break;
817 } 817 }
818 case FIELD: 818 case FIELD:
819 value = JSObject::FastPropertyAt(handle(result->holder(), isolate), 819 value = JSObject::FastPropertyAt(handle(result->holder(), isolate),
820 result->representation(), 820 result->representation(),
821 result->GetFieldIndex().field_index()); 821 result->GetFieldIndex().field_index());
822 break; 822 break;
823 case CONSTANT: 823 case CONSTANT:
824 return handle(result->GetConstant(), isolate); 824 return handle(result->GetConstant(), isolate);
825 case CALLBACKS: 825 case CALLBACKS:
(...skipping 15664 matching lines...) Expand 10 before | Expand all | Expand 10 after
16490 #define ERROR_MESSAGES_TEXTS(C, T) T, 16490 #define ERROR_MESSAGES_TEXTS(C, T) T,
16491 static const char* error_messages_[] = { 16491 static const char* error_messages_[] = {
16492 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16492 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16493 }; 16493 };
16494 #undef ERROR_MESSAGES_TEXTS 16494 #undef ERROR_MESSAGES_TEXTS
16495 return error_messages_[reason]; 16495 return error_messages_[reason];
16496 } 16496 }
16497 16497
16498 16498
16499 } } // namespace v8::internal 16499 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698